Simplify parseHtmlFragment

cburgmer · cburgmer · commit e340fd902d33 · 2016-07-07T22:06:07.000+08:00
diff --git a/src/browser.js b/src/browser.js
@@ -208,12 +208,16 @@ var browser = (function (util, proxies, ayepromise, sanedomparsererror, theWindo
     };
 
     module.parseHtmlFragment = function (htmlFragment) {
-        var doc = theWindow.document.implementation.createHTMLDocument(''),
-            fragmentContainer = doc.createElement('div');
-        fragmentContainer.innerHTML = htmlFragment;
-        doc.documentElement.appendChild(fragmentContainer);
+        var doc = theWindow.document.implementation.createHTMLDocument('');
+        doc.documentElement.innerHTML = htmlFragment;
+
+        var element = doc.querySelector('body').firstChild;
 
-        return fragmentContainer.firstChild;
+        if (!element) {
+            throw "Invalid source";
+        }
+
+        return element;
     };
 
     var addHTMLTagAttributes = function (doc, html) {
diff --git a/test/specs/BrowserSpec.js b/test/specs/BrowserSpec.js
@@ -206,6 +206,19 @@ describe("Browser functions", function () {
         });
     });
 
+    describe("parseHtmlFragment", function () {
+        it("should parse a single div", function () {
+            var element = browser.parseHtmlFragment('<div id="the_div"></div>');
+
+            expect(element.tagName.toLowerCase()).toEqual('div');
+            expect(element.id).toEqual('the_div');
+        });
+
+        it("should raise error when parsing an otherwise empty body element", function () {
+            expect(function () { browser.parseHtmlFragment('<body></body>'); }).toThrow("Invalid source");
+        });
+    });
+
     describe("parseHTML", function () {
         var oldDOMParser = window.DOMParser;
 
