JIT: Switch GetElement and WithElement to native sized indices #118990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
tannergooding
approved these changes
Aug 22, 2025
This was referenced Aug 22, 2025
Open
tannergooding
approved these changes
Aug 25, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes JIT compiler issue #118974 by updating SIMD GetElement and WithElement intrinsics to use native-sized indices for address calculations. The change ensures consistency across platforms and prevents potential issues with 32-bit indices on 64-bit systems.
Key changes:
- Added normalization of indices to native size before address calculations
- Introduced
NormalizeIndexToNativeSizedhelper method for type conversion - Updated both x86/x64 and ARM architectures to use consistent index handling
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/jit/lower.h | Added declaration for NormalizeIndexToNativeSized helper method |
| src/coreclr/jit/lower.cpp | Implemented NormalizeIndexToNativeSized method to convert indices to native size |
| src/coreclr/jit/lowerxarch.cpp | Updated GetElement and WithElement lowering to normalize indices on x86/x64 |
| src/coreclr/jit/lowerarmarch.cpp | Updated GetElement lowering to normalize indices on ARM |
| src/coreclr/jit/hwintrinsiccodegenxarch.cpp | Added assertions to verify indices are native-sized during code generation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #118974