use dimensions instead of float for pathWidth

renaudcerrato · renaudcerrato · commit 3e93d3f196da · 2015-11-13T08:54:49.000-05:00
diff --git a/android-pathview/src/main/java/com/eftimoff/androipathview/PathView.java b/android-pathview/src/main/java/com/eftimoff/androipathview/PathView.java
@@ -126,7 +126,7 @@ private void getFromAttributes(Context context, AttributeSet attrs) {
         try {
             if (a != null) {
                 paint.setColor(a.getColor(R.styleable.PathView_pathColor, 0xff00ff00));
-                paint.setStrokeWidth(a.getFloat(R.styleable.PathView_pathWidth, 8.0f));
+                paint.setStrokeWidth(a.getDimensionPixelSize(R.styleable.PathView_pathWidth, 8));
                 svgResourceId = a.getResourceId(R.styleable.PathView_svg, 0);
             }
         } finally {
diff --git a/android-pathview/src/main/res/values/attrs.xml b/android-pathview/src/main/res/values/attrs.xml
@@ -1,11 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
   <declare-styleable name="PathView">
-    <attr name="pathColor"
-        format="color"/>
-    <attr name="pathWidth"
-        format="float"/>
-    <attr name="svg"
-        format="reference"/>
+    <attr name="pathColor" format="color|reference"/>
+    <attr name="pathWidth" format="dimension|reference"/>
+    <attr name="svg" format="reference"/>
   </declare-styleable>
 </resources>
diff --git a/sample/src/main/res/layout/activity_second.xml b/sample/src/main/res/layout/activity_second.xml
@@ -13,6 +13,6 @@
         android:layout_height="350dp"
         app:svg="@raw/monitor"
         app:pathColor="@android:color/white"
-        app:pathWidth="2"/>
+        app:pathWidth="2dp"/>
 
 </LinearLayout>
diff --git a/sample/src/main/res/layout/fragment_issues.xml b/sample/src/main/res/layout/fragment_issues.xml
@@ -10,7 +10,7 @@
         android:id="@+id/pathView"
         android:layout_width="58dp"
         app:pathColor="@android:color/holo_red_dark"
-        app:pathWidth="2"
+        app:pathWidth="2dp"
         app:svg="@raw/issues"
         android:layout_height="58dp"/>
 
diff --git a/sample/src/main/res/layout/fragment_logout.xml b/sample/src/main/res/layout/fragment_logout.xml
@@ -10,7 +10,7 @@
         android:id="@+id/pathView"
         android:layout_width="150dp"
         app:pathColor="@android:color/black"
-        app:pathWidth="1"
+        app:pathWidth="1dp"
         android:layout_gravity="center"
         app:svg="@raw/logout"
         android:layout_height="150dp"/>
diff --git a/sample/src/main/res/layout/fragment_settings.xml b/sample/src/main/res/layout/fragment_settings.xml
@@ -10,7 +10,7 @@
         android:id="@+id/pathView"
         android:layout_width="match_parent"
         app:pathColor="@android:color/white"
-        app:pathWidth="10"
+        app:pathWidth="10dp"
         app:svg="@raw/settings"
         android:layout_height="match_parent"/>
 

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ private void getFromAttributes(Context context, AttributeSet attrs) {`
`126`	`126`	`try {`
`127`	`127`	`if (a != null) {`
`128`	`128`	`paint.setColor(a.getColor(R.styleable.PathView_pathColor, 0xff00ff00));`
`129`		`- paint.setStrokeWidth(a.getFloat(R.styleable.PathView_pathWidth, 8.0f));`
	`129`	`+ paint.setStrokeWidth(a.getDimensionPixelSize(R.styleable.PathView_pathWidth, 8));`
`130`	`130`	`svgResourceId = a.getResourceId(R.styleable.PathView_svg, 0);`
`131`	`131`	`}`
`132`	`132`	`} finally {`