Change condition return signature (#1809)

brianhall · web-flow · commit 8b2c63a41869 · 2025-07-09T21:16:40.000+02:00
* Change condition return signature

* Fix formatting
diff --git a/injected/integration-test/broker-protection-tests/broker-protection.spec.js b/injected/integration-test/broker-protection-tests/broker-protection.spec.js
@@ -682,7 +682,7 @@ test.describe('Broker Protection communications', () => {
             expect(successResponse.actions.length).toBeGreaterThan(0);
         });
 
-        test('a condition with failSilently returns success with empty response', async ({ page }, workerInfo) => {
+        test('a condition with failSilently returns success with empty actions array', async ({ page }, workerInfo) => {
             const dbp = BrokerProtectionPage.create(page, workerInfo.project.use);
             await dbp.enabled();
             await dbp.navigatesTo('form.html');
@@ -692,7 +692,10 @@ test.describe('Broker Protection communications', () => {
 
             // Check that the response does not contain an actions array
             const successResponse = await dbp.getSuccessResponse();
-            expect(successResponse).toBeNull();
+
+            expect(successResponse).toHaveProperty('actions');
+            expect(Array.isArray(successResponse.actions)).toBe(true);
+            expect(successResponse.actions.length).toBe(0);
         });
 
         test('a failing condition returns error', async ({ page }, workerInfo) => {
diff --git a/injected/src/features/broker-protection/actions/condition.js b/injected/src/features/broker-protection/actions/condition.js
@@ -35,5 +35,5 @@ export function condition(action, root = document) {
         });
     }
 
-    return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: null });
+    return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: { actions: [] } });
 }

Original file line number	Diff line number	Diff line change
`@@ -35,5 +35,5 @@ export function condition(action, root = document) {`
`35`	`35`	`});`
`36`	`36`	`}`
`37`	`37`
`38`		`- return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: null });`
	`38`	`+ return new SuccessResponse({ actionID: action.id, actionType: action.actionType, response: { actions: [] } });`
`39`	`39`	`}`