actions: remove some events when disabling action

taye · taye · commit cca4e2606087 · 2016-08-27T18:03:18.000+02:00
Close taye#404
diff --git a/src/actions/drag.js b/src/actions/drag.js
@@ -158,6 +158,10 @@ Interactable.prototype.draggable = function (options) {
   if (utils.isBool(options)) {
     this.options.drag.enabled = options;
 
+    if (!options) {
+      this.ondragstart = this.ondragstart = this.ondragend = null;
+    }
+
     return this;
   }
 
diff --git a/src/actions/drop.js b/src/actions/drop.js
@@ -346,6 +346,11 @@ Interactable.prototype.dropzone = function (options) {
   if (utils.isBool(options)) {
     this.options.drop.enabled = options;
 
+    if (!options) {
+      this.ondragenter = this.ondragleave = this.ondrop
+        = this.ondropactivate = this.ondropdeactivate = null;
+    }
+
     return this;
   }
 
diff --git a/src/actions/gesture.js b/src/actions/gesture.js
@@ -113,6 +113,10 @@ Interactable.prototype.gesturable = function (options) {
   if (utils.isBool(options)) {
     this.options.gesture.enabled = options;
 
+    if (!options) {
+      this.ongesturestart = this.ongesturestart = this.ongestureend = null;
+    }
+
     return this;
   }
 
diff --git a/src/actions/resize.js b/src/actions/resize.js
@@ -361,6 +361,10 @@ Interactable.prototype.resizable = function (options) {
   if (utils.isBool(options)) {
     this.options.resize.enabled = options;
 
+    if (!options) {
+      this.onresizestart = this.onresizestart = this.onresizeend = null;
+    }
+
     return this;
   }
   return this.options.resize;

Original file line number	Diff line number	Diff line change
`@@ -158,6 +158,10 @@ Interactable.prototype.draggable = function (options) {`
`158`	`158`	`if (utils.isBool(options)) {`
`159`	`159`	`this.options.drag.enabled = options;`
`160`	`160`
	`161`	`+ if (!options) {`
	`162`	`+ this.ondragstart = this.ondragstart = this.ondragend = null;`
	`163`	`+ }`
	`164`	`+`
`161`	`165`	`return this;`
`162`	`166`	`}`
`163`	`167`
Original file line number	Diff line number	Diff line change
`@@ -113,6 +113,10 @@ Interactable.prototype.gesturable = function (options) {`
`113`	`113`	`if (utils.isBool(options)) {`
`114`	`114`	`this.options.gesture.enabled = options;`
`115`	`115`
	`116`	`+ if (!options) {`
	`117`	`+ this.ongesturestart = this.ongesturestart = this.ongestureend = null;`
	`118`	`+ }`
	`119`	`+`
`116`	`120`	`return this;`
`117`	`121`	`}`
`118`	`122`