MIPS: mm: Add set_cpu_context() for ASID assignments

paulburton · paulburton · commit 0b317c389c67 · 2019-02-04T10:56:33.000-08:00
When we gain MMID support we'll be storing MMIDs as atomic64_t values
and accessing them via atomic64_* functions. This necessitates that we
don't use cpu_context() as the left hand side of an assignment, ie. as a
modifiable lvalue. In preparation for this introduce a new
set_cpu_context() function &amp; replace all assignments with cpu_context()
on their left hand side with an equivalent call to set_cpu_context().

To enforce that cpu_context() should not be used for assignments, we
rewrite it as a static inline function.

Signed-off-by: Paul Burton &lt;paul.burton@mips.com&gt;
Cc: linux-mips@vger.kernel.org
diff --git a/arch/mips/include/asm/mmu_context.h b/arch/mips/include/asm/mmu_context.h
@@ -88,7 +88,17 @@ static inline u64 asid_first_version(unsigned int cpu)
 	return ~asid_version_mask(cpu) + 1;
 }
 
-#define cpu_context(cpu, mm)	((mm)->context.asid[cpu])
+static inline u64 cpu_context(unsigned int cpu, const struct mm_struct *mm)
+{
+	return mm->context.asid[cpu];
+}
+
+static inline void set_cpu_context(unsigned int cpu,
+				   struct mm_struct *mm, u64 ctx)
+{
+	mm->context.asid[cpu] = ctx;
+}
+
 #define asid_cache(cpu)		(cpu_data[cpu].asid_cache)
 #define cpu_asid(cpu, mm) \
 	(cpu_context((cpu), (mm)) & cpu_asid_mask(&cpu_data[cpu]))
@@ -111,7 +121,7 @@ init_new_context(struct task_struct *tsk, struct mm_struct *mm)
 	int i;
 
 	for_each_possible_cpu(i)
-		cpu_context(i, mm) = 0;
+		set_cpu_context(i, mm, 0);
 
 	mm->context.bd_emupage_allocmap = NULL;
 	spin_lock_init(&mm->context.bd_emupage_lock);
@@ -175,7 +185,7 @@ drop_mmu_context(struct mm_struct *mm)
 		htw_start();
 	} else {
 		/* will get a new context next time */
-		cpu_context(cpu, mm) = 0;
+		set_cpu_context(cpu, mm, 0);
 	}
 
 	local_irq_restore(flags);
diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
@@ -537,7 +537,7 @@ void flush_tlb_mm(struct mm_struct *mm)
 
 		for_each_online_cpu(cpu) {
 			if (cpu != smp_processor_id() && cpu_context(cpu, mm))
-				cpu_context(cpu, mm) = 0;
+				set_cpu_context(cpu, mm, 0);
 		}
 	}
 	drop_mmu_context(mm);
@@ -583,7 +583,7 @@ void flush_tlb_range(struct vm_area_struct *vma, unsigned long start, unsigned l
 			 * mm has been completely unused by that CPU.
 			 */
 			if (cpu != smp_processor_id() && cpu_context(cpu, mm))
-				cpu_context(cpu, mm) = !exec;
+				set_cpu_context(cpu, mm, !exec);
 		}
 	}
 	local_flush_tlb_range(vma, start, end);
@@ -635,7 +635,7 @@ void flush_tlb_page(struct vm_area_struct *vma, unsigned long page)
 			 * by that CPU.
 			 */
 			if (cpu != smp_processor_id() && cpu_context(cpu, vma->vm_mm))
-				cpu_context(cpu, vma->vm_mm) = 1;
+				set_cpu_context(cpu, vma->vm_mm, 1);
 		}
 	}
 	local_flush_tlb_page(vma, page);
diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c
@@ -1019,7 +1019,7 @@ static void kvm_mips_change_entryhi(struct kvm_vcpu *vcpu,
 		get_new_mmu_context(kern_mm);
 		for_each_possible_cpu(i)
 			if (i != cpu)
-				cpu_context(i, kern_mm) = 0;
+				set_cpu_context(i, kern_mm, 0);
 		preempt_enable();
 	}
 	kvm_write_c0_guest_entryhi(cop0, entryhi);
@@ -1090,8 +1090,8 @@ static void kvm_mips_invalidate_guest_tlb(struct kvm_vcpu *vcpu,
 		if (i == cpu)
 			continue;
 		if (user)
-			cpu_context(i, user_mm) = 0;
-		cpu_context(i, kern_mm) = 0;
+			set_cpu_context(i, user_mm, 0);
+		set_cpu_context(i, kern_mm, 0);
 	}
 
 	preempt_enable();
diff --git a/arch/mips/kvm/trap_emul.c b/arch/mips/kvm/trap_emul.c
@@ -1098,8 +1098,8 @@ static void kvm_trap_emul_check_requests(struct kvm_vcpu *vcpu, int cpu,
 		kvm_mips_flush_gva_pt(kern_mm->pgd, KMF_GPA | KMF_KERN);
 		kvm_mips_flush_gva_pt(user_mm->pgd, KMF_GPA | KMF_USER);
 		for_each_possible_cpu(i) {
-			cpu_context(i, kern_mm) = 0;
-			cpu_context(i, user_mm) = 0;
+			set_cpu_context(i, kern_mm, 0);
+			set_cpu_context(i, user_mm, 0);
 		}
 
 		/* Generate new ASID for current mode */
@@ -1211,7 +1211,7 @@ static void kvm_trap_emul_vcpu_reenter(struct kvm_run *run,
 		if (gasid != vcpu->arch.last_user_gasid) {
 			kvm_mips_flush_gva_pt(user_mm->pgd, KMF_USER);
 			for_each_possible_cpu(i)
-				cpu_context(i, user_mm) = 0;
+				set_cpu_context(i, user_mm, 0);
 			vcpu->arch.last_user_gasid = gasid;
 		}
 	}
diff --git a/arch/mips/mm/context.c b/arch/mips/mm/context.c
@@ -15,7 +15,8 @@ void get_new_mmu_context(struct mm_struct *mm)
 		local_flush_tlb_all();	/* start new asid cycle */
 	}
 
-	cpu_context(cpu, mm) = asid_cache(cpu) = asid;
+	set_cpu_context(cpu, mm, asid);
+	asid_cache(cpu) = asid;
 }
 
 void check_mmu_context(struct mm_struct *mm)

Original file line number	Diff line number	Diff line change
`@@ -537,7 +537,7 @@ void flush_tlb_mm(struct mm_struct *mm)`
`537`	`537`
`538`	`538`	`for_each_online_cpu(cpu) {`
`539`	`539`	`if (cpu != smp_processor_id() && cpu_context(cpu, mm))`
`540`		`- cpu_context(cpu, mm) = 0;`
	`540`	`+ set_cpu_context(cpu, mm, 0);`
`541`	`541`	`}`
`542`	`542`	`}`
`543`	`543`	`drop_mmu_context(mm);`
`@@ -583,7 +583,7 @@ void flush_tlb_range(struct vm_area_struct *vma, unsigned long start, unsigned l`
`583`	`583`	`* mm has been completely unused by that CPU.`
`584`	`584`	`*/`
`585`	`585`	`if (cpu != smp_processor_id() && cpu_context(cpu, mm))`
`586`		`- cpu_context(cpu, mm) = !exec;`
	`586`	`+ set_cpu_context(cpu, mm, !exec);`
`587`	`587`	`}`
`588`	`588`	`}`
`589`	`589`	`local_flush_tlb_range(vma, start, end);`
`@@ -635,7 +635,7 @@ void flush_tlb_page(struct vm_area_struct *vma, unsigned long page)`
`635`	`635`	`* by that CPU.`
`636`	`636`	`*/`
`637`	`637`	`if (cpu != smp_processor_id() && cpu_context(cpu, vma->vm_mm))`
`638`		`- cpu_context(cpu, vma->vm_mm) = 1;`
	`638`	`+ set_cpu_context(cpu, vma->vm_mm, 1);`
`639`	`639`	`}`
`640`	`640`	`}`
`641`	`641`	`local_flush_tlb_page(vma, page);`
Original file line number	Diff line number	Diff line change
`@@ -1098,8 +1098,8 @@ static void kvm_trap_emul_check_requests(struct kvm_vcpu *vcpu, int cpu,`
`1098`	`1098`	`kvm_mips_flush_gva_pt(kern_mm->pgd, KMF_GPA \| KMF_KERN);`
`1099`	`1099`	`kvm_mips_flush_gva_pt(user_mm->pgd, KMF_GPA \| KMF_USER);`
`1100`	`1100`	`for_each_possible_cpu(i) {`
`1101`		`- cpu_context(i, kern_mm) = 0;`
`1102`		`- cpu_context(i, user_mm) = 0;`
	`1101`	`+ set_cpu_context(i, kern_mm, 0);`
	`1102`	`+ set_cpu_context(i, user_mm, 0);`
`1103`	`1103`	`}`
`1104`	`1104`
`1105`	`1105`	`/* Generate new ASID for current mode */`
`@@ -1211,7 +1211,7 @@ static void kvm_trap_emul_vcpu_reenter(struct kvm_run *run,`
`1211`	`1211`	`if (gasid != vcpu->arch.last_user_gasid) {`
`1212`	`1212`	`kvm_mips_flush_gva_pt(user_mm->pgd, KMF_USER);`
`1213`	`1213`	`for_each_possible_cpu(i)`
`1214`		`- cpu_context(i, user_mm) = 0;`
	`1214`	`+ set_cpu_context(i, user_mm, 0);`
`1215`	`1215`	`vcpu->arch.last_user_gasid = gasid;`
`1216`	`1216`	`}`
`1217`	`1217`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,8 @@ void get_new_mmu_context(struct mm_struct *mm)`
`15`	`15`	`local_flush_tlb_all(); /* start new asid cycle */`
`16`	`16`	`}`
`17`	`17`
`18`		`- cpu_context(cpu, mm) = asid_cache(cpu) = asid;`
	`18`	`+ set_cpu_context(cpu, mm, asid);`
	`19`	`+ asid_cache(cpu) = asid;`
`19`	`20`	`}`
`20`	`21`
`21`	`22`	`void check_mmu_context(struct mm_struct *mm)`