Skip to content

Commit 18ec3c1

Browse files
Dan CarpenterBen Skeggs
authored andcommitted
drm/nouveau/dmem: Fix a NULL vs IS_ERR() check
The hmm_devmem_add() function doesn't return NULL, it returns error pointers. Fixes: 5be73b6 ("drm/nouveau/dmem: device memory helpers for SVM") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
1 parent 2219c9e commit 18ec3c1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/nouveau/nouveau_dmem.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -621,7 +621,7 @@ nouveau_dmem_init(struct nouveau_drm *drm)
621621
*/
622622
drm->dmem->devmem = hmm_devmem_add(&nouveau_dmem_devmem_ops,
623623
device, size);
624-
if (drm->dmem->devmem == NULL) {
624+
if (IS_ERR(drm->dmem->devmem)) {
625625
kfree(drm->dmem);
626626
drm->dmem = NULL;
627627
return;

0 commit comments

Comments
 (0)