Fix pattern handling optimalization

pavelmachek · jacek-anaszewski · commit 1b50bb4d36e8 · 2018-10-25T20:47:46.000+02:00
Check for zero duration before skipping step. This fixes pattern

    echo "0 1000 10 2550 0 1000" &gt; pattern

which should do [  .-xXx-.] but does [   Xx-.]

Signed-off-by: Pavel Machek &lt;pavel@ucw.cz&gt;
Suggested-by: Jacek Anaszewski &lt;jacek.anaszewski@gmail.com&gt;
Signed-off-by: Jacek Anaszewski &lt;jacek.anaszewski@gmail.com&gt;
diff --git a/drivers/leds/trigger/ledtrig-pattern.c b/drivers/leds/trigger/ledtrig-pattern.c
@@ -87,9 +87,10 @@ static void pattern_trig_timer_function(struct timer_list *t)
 					   data->curr->brightness);
 			mod_timer(&data->timer,
 				  jiffies + msecs_to_jiffies(data->curr->delta_t));
-
-			/* Skip the tuple with zero duration */
-			pattern_trig_update_patterns(data);
+			if (!data->next->delta_t) {
+				/* Skip the tuple with zero duration */
+				pattern_trig_update_patterns(data);
+			}
 			/* Select next tuple */
 			pattern_trig_update_patterns(data);
 		} else {
