gpio: altera-a10sr: Set proper output level for direction_output

AxelLin · brgl · commit 2095a45e345e · 2019-01-23T17:24:02.000+01:00
The altr_a10sr_gpio_direction_output should set proper output level based on the value argument. Fixes: 26a48c4 ("gpio: altera-a10sr: Add A10 System Resource Chip GPIO support.") Cc: <stable@vger.kernel.org> Signed-off-by: Axel Lin <axel.lin@ingics.com> Tested by: Thor Thayer <thor.thayer@linux.intel.com> Reviewed by: Thor Thayer <thor.thayer@linux.intel.com> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
diff --git a/drivers/gpio/gpio-altera-a10sr.c b/drivers/gpio/gpio-altera-a10sr.c
@@ -66,8 +66,10 @@ static int altr_a10sr_gpio_direction_input(struct gpio_chip *gc,
 static int altr_a10sr_gpio_direction_output(struct gpio_chip *gc,
 					    unsigned int nr, int value)
 {
-	if (nr <= (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT))
+	if (nr <= (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT)) {
+		altr_a10sr_gpio_set(gc, nr, value);
 		return 0;
+	}
 	return -EINVAL;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -66,8 +66,10 @@ static int altr_a10sr_gpio_direction_input(struct gpio_chip *gc,`
`66`	`66`	`static int altr_a10sr_gpio_direction_output(struct gpio_chip *gc,`
`67`	`67`	`unsigned int nr, int value)`
`68`	`68`	`{`
`69`		`- if (nr <= (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT))`
	`69`	`+ if (nr <= (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT)) {`
	`70`	`+ altr_a10sr_gpio_set(gc, nr, value);`
`70`	`71`	`return 0;`
	`72`	`+ }`
`71`	`73`	`return -EINVAL;`
`72`	`74`	`}`
`73`	`75`