OF: properties: add missing of_node_put

JuliaLawall · robherring · commit 28b170e88bc0 · 2019-01-16T12:49:53.000-06:00
Add an of_node_put when the result of of_graph_get_remote_port_parent is not available. The semantic match that finds this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @r exists@ local idexpression e; expression x; @@ e = of_graph_get_remote_port_parent(...); ... when != x = e when != true e == NULL when != of_node_put(e) when != of_fwnode_handle(e) ( return e; | *return ...; ) // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Cc: stable@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org>
diff --git a/drivers/of/property.c b/drivers/of/property.c
@@ -806,6 +806,7 @@ struct device_node *of_graph_get_remote_node(const struct device_node *node,
 
 	if (!of_device_is_available(remote)) {
 		pr_debug("not available for remote node\n");
+		of_node_put(remote);
 		return NULL;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -806,6 +806,7 @@ struct device_node of_graph_get_remote_node(const struct device_node node,`
`806`	`806`
`807`	`807`	`if (!of_device_is_available(remote)) {`
`808`	`808`	`pr_debug("not available for remote node\n");`
	`809`	`+ of_node_put(remote);`
`809`	`810`	`return NULL;`
`810`	`811`	`}`
`811`	`812`