libceph: no need to call osd_req_opcode_valid() in osd_req_encode_op()

idryomov · idryomov · commit 41a264e1b30c · 2018-10-22T10:28:21.000+02:00
Any uninitialized or unknown ops will be caught by the default clause
anyway.

Signed-off-by: Ilya Dryomov &lt;idryomov@gmail.com&gt;
diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
@@ -903,12 +903,6 @@ static void ceph_osdc_msg_data_add(struct ceph_msg *msg,
 static u32 osd_req_encode_op(struct ceph_osd_op *dst,
 			     const struct ceph_osd_req_op *src)
 {
-	if (WARN_ON(!osd_req_opcode_valid(src->op))) {
-		pr_err("unrecognized osd opcode %d\n", src->op);
-
-		return 0;
-	}
-
 	switch (src->op) {
 	case CEPH_OSD_OP_STAT:
 		break;
