PM / Domains: Improve warn for multiple states but no governor

Aisheng Dong · rafaeljw · commit 46b7fe94995f · 2019-03-11T11:26:45.000+01:00
It's possible a PM domain defines only one state and it does not need
a governor to work. For such case, a warning actually is not necessary.

Signed-off-by: Dong Aisheng &lt;aisheng.dong@nxp.com&gt;
Reviewed-by: Ulf Hansson &lt;ulf.hansson@linaro.org&gt;
Signed-off-by: Rafael J. Wysocki &lt;rafael.j.wysocki@intel.com&gt;
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
@@ -1766,7 +1766,7 @@ int pm_genpd_init(struct generic_pm_domain *genpd,
 		ret = genpd_set_default_power_state(genpd);
 		if (ret)
 			return ret;
-	} else if (!gov) {
+	} else if (!gov && genpd->state_count > 1) {
 		pr_warn("%s : no governor for states\n", genpd->name);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1766,7 +1766,7 @@ int pm_genpd_init(struct generic_pm_domain *genpd,`
`1766`	`1766`	`ret = genpd_set_default_power_state(genpd);`
`1767`	`1767`	`if (ret)`
`1768`	`1768`	`return ret;`
`1769`		`- } else if (!gov) {`
	`1769`	`+ } else if (!gov && genpd->state_count > 1) {`
`1770`	`1770`	`pr_warn("%s : no governor for states\n", genpd->name);`
`1771`	`1771`	`}`
`1772`	`1772`