perf tests evsel-tp-sched: Fix bitwise operator

GustavoARSilva · acmel · commit 489338a717a0 · 2019-02-04T11:32:14.000-03:00
Notice that the use of the bitwise OR operator '|' always leads to true in this particular case, which seems a bit suspicious due to the context in which this expression is being used. Fix this by using bitwise AND operator '&' instead. This bug was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Acked-by: Jiri Olsa <jolsa@kernel.org> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: stable@vger.kernel.org Fixes: 6a6cd11 ("perf test: Add test for the sched tracepoint format fields") Link: http://lkml.kernel.org/r/20190122233439.GA5868@embeddedor Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
diff --git a/tools/perf/tests/evsel-tp-sched.c b/tools/perf/tests/evsel-tp-sched.c
@@ -17,7 +17,7 @@ static int perf_evsel__test_field(struct perf_evsel *evsel, const char *name,
 		return -1;
 	}
 
-	is_signed = !!(field->flags | TEP_FIELD_IS_SIGNED);
+	is_signed = !!(field->flags & TEP_FIELD_IS_SIGNED);
 	if (should_be_signed && !is_signed) {
 		pr_debug("%s: \"%s\" signedness(%d) is wrong, should be %d\n",
 			 evsel->name, name, is_signed, should_be_signed);

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ static int perf_evsel__test_field(struct perf_evsel evsel, const char name,`
`17`	`17`	`return -1;`
`18`	`18`	`}`
`19`	`19`
`20`		`- is_signed = !!(field->flags \| TEP_FIELD_IS_SIGNED);`
	`20`	`+ is_signed = !!(field->flags & TEP_FIELD_IS_SIGNED);`
`21`	`21`	`if (should_be_signed && !is_signed) {`
`22`	`22`	`pr_debug("%s: \"%s\" signedness(%d) is wrong, should be %d\n",`
`23`	`23`	`evsel->name, name, is_signed, should_be_signed);`