mips: ralink: no need to check return value of debugfs_create functions

gregkh · paulburton · commit 4c90de4dd33d · 2019-01-22T11:17:20.000-08:00
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: John Crispin &lt;john@phrozen.org&gt;
Cc: Ralf Baechle &lt;ralf@linux-mips.org&gt;
Cc: Paul Burton &lt;paul.burton@mips.com&gt;
Cc: James Hogan &lt;jhogan@kernel.org&gt;
Cc: linux-mips@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
Signed-off-by: Paul Burton &lt;paul.burton@mips.com&gt;
diff --git a/arch/mips/ralink/bootrom.c b/arch/mips/ralink/bootrom.c
@@ -35,13 +35,7 @@ static const struct file_operations bootrom_file_ops = {
 
 static int bootrom_setup(void)
 {
-	if (!debugfs_create_file("bootrom", 0444,
-			NULL, NULL, &bootrom_file_ops)) {
-		pr_err("Failed to create bootrom debugfs file\n");
-
-		return -EINVAL;
-	}
-
+	debugfs_create_file("bootrom", 0444, NULL, NULL, &bootrom_file_ops);
 	return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -35,13 +35,7 @@ static const struct file_operations bootrom_file_ops = {`
`35`	`35`
`36`	`36`	`static int bootrom_setup(void)`
`37`	`37`	`{`
`38`		`- if (!debugfs_create_file("bootrom", 0444,`
`39`		`- NULL, NULL, &bootrom_file_ops)) {`
`40`		`- pr_err("Failed to create bootrom debugfs file\n");`
`41`		`-`
`42`		`- return -EINVAL;`
`43`		`- }`
`44`		`-`
	`38`	`+ debugfs_create_file("bootrom", 0444, NULL, NULL, &bootrom_file_ops);`
`45`	`39`	`return 0;`
`46`	`40`	`}`
`47`	`41`