net: hns: Fixes the missing put_device in positive leg for roce reset

Salil Mehta · davem330 · commit 4d96e13ee9cd · 2019-02-18T17:45:00.000-08:00
This patch fixes the missing device reference release-after-use in the positive leg of the roce reset API of the HNS DSAF. Fixes: c969c6e ("net: hns: Fix object reference leaks in hns_dsaf_roce_reset()") Reported-by: John Garry <john.garry@huawei.com> Signed-off-by: Salil Mehta <salil.mehta@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
@@ -3128,6 +3128,9 @@ int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset)
 		dsaf_set_bit(credit, DSAF_SBM_ROCEE_CFG_CRD_EN_B, 1);
 		dsaf_write_dev(dsaf_dev, DSAF_SBM_ROCEE_CFG_REG_REG, credit);
 	}
+
+	put_device(&pdev->dev);
+
 	return 0;
 }
 EXPORT_SYMBOL(hns_dsaf_roce_reset);

Original file line number	Diff line number	Diff line change
`@@ -3128,6 +3128,9 @@ int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset)`
`3128`	`3128`	`dsaf_set_bit(credit, DSAF_SBM_ROCEE_CFG_CRD_EN_B, 1);`
`3129`	`3129`	`dsaf_write_dev(dsaf_dev, DSAF_SBM_ROCEE_CFG_REG_REG, credit);`
`3130`	`3130`	`}`
	`3131`	`+`
	`3132`	`+ put_device(&pdev->dev);`
	`3133`	`+`
`3131`	`3134`	`return 0;`
`3132`	`3135`	`}`
`3133`	`3136`	`EXPORT_SYMBOL(hns_dsaf_roce_reset);`