xfrm: fix gro_cells leak when remove virtual xfrm interfaces

lrq-max · klassert · commit 4da402597c2b · 2018-10-02T08:11:45.000+02:00
The device gro_cells has been initialized, it should be freed, otherwise it will be leaked Fixes: f203b76 ("xfrm: Add virtual xfrm interfaces") Signed-off-by: Zhang Yu <zhangyu31@baidu.com> Signed-off-by: Li RongQing <lirongqing@baidu.com> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c
@@ -116,6 +116,9 @@ static void xfrmi_unlink(struct xfrmi_net *xfrmn, struct xfrm_if *xi)
 
 static void xfrmi_dev_free(struct net_device *dev)
 {
+	struct xfrm_if *xi = netdev_priv(dev);
+
+	gro_cells_destroy(&xi->gro_cells);
 	free_percpu(dev->tstats);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -116,6 +116,9 @@ static void xfrmi_unlink(struct xfrmi_net xfrmn, struct xfrm_if xi)`
`116`	`116`
`117`	`117`	`static void xfrmi_dev_free(struct net_device *dev)`
`118`	`118`	`{`
	`119`	`+ struct xfrm_if *xi = netdev_priv(dev);`
	`120`	`+`
	`121`	`+ gro_cells_destroy(&xi->gro_cells);`
`119`	`122`	`free_percpu(dev->tstats);`
`120`	`123`	`}`
`121`	`124`