ACPI / utils: Drop reference in test for device presence

andy-shev · rafaeljw · commit 54e3aca84e57 · 2019-03-19T22:34:21.000+01:00
When commit 8661423 ("ACPI / utils: Add new acpi_dev_present helper") introduced acpi_dev_present(), it missed the fact that bus_find_device() took a reference on the device found by it and the callers of acpi_dev_present() don't drop that reference. Drop the reference on the device in acpi_dev_present(). Fixes: 8661423 ("ACPI / utils: Add new acpi_dev_present helper") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
@@ -800,6 +800,7 @@ bool acpi_dev_present(const char *hid, const char *uid, s64 hrv)
 	match.hrv = hrv;
 
 	dev = bus_find_device(&acpi_bus_type, NULL, &match, acpi_dev_match_cb);
+	put_device(dev);
 	return !!dev;
 }
 EXPORT_SYMBOL(acpi_dev_present);

Original file line number	Diff line number	Diff line change
`@@ -800,6 +800,7 @@ bool acpi_dev_present(const char hid, const char uid, s64 hrv)`
`800`	`800`	`match.hrv = hrv;`
`801`	`801`
`802`	`802`	`dev = bus_find_device(&acpi_bus_type, NULL, &match, acpi_dev_match_cb);`
	`803`	`+ put_device(dev);`
`803`	`804`	`return !!dev;`
`804`	`805`	`}`
`805`	`806`	`EXPORT_SYMBOL(acpi_dev_present);`