null_blk: add lock drop/acquire annotation

axboe · axboe · commit 61884de08f83 · 2018-08-09T14:22:41.000-06:00
sparse complains:

drivers/block/null_blk_main.c:816:24: sparse: context imbalance in 'null_insert_page' - unexpected unlock

Fix it by adding the necessary annotations to the function.

Signed-off-by: Jens Axboe &lt;axboe@kernel.dk&gt;
diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c
@@ -804,7 +804,9 @@ static struct nullb_page *null_lookup_page(struct nullb *nullb,
 }
 
 static struct nullb_page *null_insert_page(struct nullb *nullb,
-	sector_t sector, bool ignore_cache)
+					   sector_t sector, bool ignore_cache)
+	__releases(&nullb->lock)
+	__acquires(&nullb->lock)
 {
 	u64 idx;
 	struct nullb_page *t_page;

Original file line number	Diff line number	Diff line change
`@@ -804,7 +804,9 @@ static struct nullb_page null_lookup_page(struct nullb nullb,`
`804`	`804`	`}`
`805`	`805`
`806`	`806`	`static struct nullb_page null_insert_page(struct nullb nullb,`
`807`		`- sector_t sector, bool ignore_cache)`
	`807`	`+ sector_t sector, bool ignore_cache)`
	`808`	`+ __releases(&nullb->lock)`
	`809`	`+ __acquires(&nullb->lock)`
`808`	`810`	`{`
`809`	`811`	`u64 idx;`
`810`	`812`	`struct nullb_page *t_page;`