drm/amdgpu: Fix vce work queue was not cancelled when suspend

Rex Zhu · alexdeucher · commit 61ea6f583197 · 2018-09-27T10:01:20.000-05:00
The vce cancel_delayed_work_sync never be called.
driver call the function in error path.

This caused the A+A suspend hang when runtime pm enebled.
As we will visit the smu in the idle queue. this will cause
smu hang because the dgpu has been suspend, and the dgpu also
will be waked up. As the smu has been hang, so the dgpu resume
will failed.

Reviewed-by: Christian König &lt;christian.koenig@amd.com&gt;
Reviewed-by: Feifei Xu &lt;Feifei.Xu@amd.com&gt;
Signed-off-by: Rex Zhu &lt;Rex.Zhu@amd.com&gt;
Signed-off-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
Cc: stable@vger.kernel.org
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
@@ -258,6 +258,8 @@ int amdgpu_vce_suspend(struct amdgpu_device *adev)
 {
 	int i;
 
+	cancel_delayed_work_sync(&adev->vce.idle_work);
+
 	if (adev->vce.vcpu_bo == NULL)
 		return 0;
 
@@ -268,7 +270,6 @@ int amdgpu_vce_suspend(struct amdgpu_device *adev)
 	if (i == AMDGPU_MAX_VCE_HANDLES)
 		return 0;
 
-	cancel_delayed_work_sync(&adev->vce.idle_work);
 	/* TODO: suspending running encoding sessions isn't supported */
 	return -EINVAL;
 }
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
@@ -153,11 +153,11 @@ int amdgpu_vcn_suspend(struct amdgpu_device *adev)
 	unsigned size;
 	void *ptr;
 
+	cancel_delayed_work_sync(&adev->vcn.idle_work);
+
 	if (adev->vcn.vcpu_bo == NULL)
 		return 0;
 
-	cancel_delayed_work_sync(&adev->vcn.idle_work);
-
 	size = amdgpu_bo_size(adev->vcn.vcpu_bo);
 	ptr = adev->vcn.cpu_addr;
 

Original file line number	Diff line number	Diff line change
`@@ -258,6 +258,8 @@ int amdgpu_vce_suspend(struct amdgpu_device *adev)`
`258`	`258`	`{`
`259`	`259`	`int i;`
`260`	`260`
	`261`	`+ cancel_delayed_work_sync(&adev->vce.idle_work);`
	`262`	`+`
`261`	`263`	`if (adev->vce.vcpu_bo == NULL)`
`262`	`264`	`return 0;`
`263`	`265`
`@@ -268,7 +270,6 @@ int amdgpu_vce_suspend(struct amdgpu_device *adev)`
`268`	`270`	`if (i == AMDGPU_MAX_VCE_HANDLES)`
`269`	`271`	`return 0;`
`270`	`272`
`271`		`- cancel_delayed_work_sync(&adev->vce.idle_work);`
`272`	`273`	`/* TODO: suspending running encoding sessions isn't supported */`
`273`	`274`	`return -EINVAL;`
`274`	`275`	`}`