Skip to content

Commit 69be198

Browse files
Alexandru Gheorghedliviu
authored andcommitted
drm: mali-dp: Call drm_crtc_vblank_reset on device init
Currently, if userspace calls drm_wait_vblank before the crtc is activated the crtc vblank_enable hook is called, which in case of malidp driver triggers some warninngs. This happens because on device init we don't inform the drm core about the vblank state by calling drm_crtc_vblank_on/off/reset which together with drm_vblank_get have some magic that prevents calling drm_vblank_enable when crtc is off. Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com> Acked-by: Liviu Dudau <liviu.dudau@arm.com> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
1 parent 4fcb7f8 commit 69be198

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/gpu/drm/arm/malidp_drv.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -754,6 +754,7 @@ static int malidp_bind(struct device *dev)
754754
drm->irq_enabled = true;
755755

756756
ret = drm_vblank_init(drm, drm->mode_config.num_crtc);
757+
drm_crtc_vblank_reset(&malidp->crtc);
757758
if (ret < 0) {
758759
DRM_ERROR("failed to initialise vblank\n");
759760
goto vblank_fail;

0 commit comments

Comments
 (0)