ext4: fix buffer leak in ext4_xattr_move_to_block() on error path

vaverin · tytso · commit 6bdc9977fcde · 2018-11-07T11:10:21.000-05:00
Fixes: 3f2571c ("ext4: factor out xattr moving") Fixes: 6dd4ee7 ("ext4: Expand extra_inodes space per ...") Reviewed-by: Jan Kara <jack@suse.cz> Signed-off-by: Vasily Averin <vvs@virtuozzo.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Cc: stable@kernel.org # 2.6.23
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
@@ -2617,6 +2617,8 @@ static int ext4_xattr_move_to_block(handle_t *handle, struct inode *inode,
 	kfree(buffer);
 	if (is)
 		brelse(is->iloc.bh);
+	if (bs)
+		brelse(bs->bh);
 	kfree(is);
 	kfree(bs);
 
