drm/amdgpu: fix invalid use of change_bit

ChristianKoenigAMD · alexdeucher · commit 72464382fc2d · 2019-03-19T14:01:42.000-05:00
We only need to clear the bit in a 32bit integer.

This fixes a crah on ARM64 and PPC64LE caused by
"drm/amdgpu: update the vm invalidation engine layout V2"

Signed-off-by: Christian König &lt;christian.koenig@amd.com&gt;
Acked-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
Cc: stable@vger.kernel.org
Signed-off-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
@@ -742,7 +742,7 @@ static int gmc_v9_0_allocate_vm_inv_eng(struct amdgpu_device *adev)
 		}
 
 		ring->vm_inv_eng = inv_eng - 1;
-		change_bit(inv_eng - 1, (unsigned long *)(&vm_inv_engs[vmhub]));
+		vm_inv_engs[vmhub] &= ~(1 << ring->vm_inv_eng);
 
 		dev_info(adev->dev, "ring %s uses VM inv eng %u on hub %u\n",
 			 ring->name, ring->vm_inv_eng, ring->funcs->vmhub);

Original file line number	Diff line number	Diff line change
`@@ -742,7 +742,7 @@ static int gmc_v9_0_allocate_vm_inv_eng(struct amdgpu_device *adev)`
`742`	`742`	`}`
`743`	`743`
`744`	`744`	`ring->vm_inv_eng = inv_eng - 1;`
`745`		`- change_bit(inv_eng - 1, (unsigned long *)(&vm_inv_engs[vmhub]));`
	`745`	`+ vm_inv_engs[vmhub] &= ~(1 << ring->vm_inv_eng);`
`746`	`746`
`747`	`747`	`dev_info(adev->dev, "ring %s uses VM inv eng %u on hub %u\n",`
`748`	`748`	`ring->name, ring->vm_inv_eng, ring->funcs->vmhub);`