drm/exynos: checking for NULL instead of IS_ERR()

Dan Carpenter · daeinki · commit 8727b230f665 · 2018-11-05T16:37:24.000+09:00
The of_drm_find_panel() function returns error pointers and never NULL but we the driver assumes that ->panel is NULL when it's not present. Fixes: 6afb772 ("drm/exynos: move connector creation to attach callback") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Inki Dae <inki.dae@samsung.com>
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1527,7 +1527,9 @@ static int exynos_dsi_host_attach(struct mipi_dsi_host *host,
 		}
 
 		dsi->panel = of_drm_find_panel(device->dev.of_node);
-		if (dsi->panel) {
+		if (IS_ERR(dsi->panel)) {
+			dsi->panel = NULL;
+		} else {
 			drm_panel_attach(dsi->panel, &dsi->connector);
 			dsi->connector.status = connector_status_connected;
 		}

Original file line number	Diff line number	Diff line change
`@@ -1527,7 +1527,9 @@ static int exynos_dsi_host_attach(struct mipi_dsi_host *host,`
`1527`	`1527`	`}`
`1528`	`1528`
`1529`	`1529`	`dsi->panel = of_drm_find_panel(device->dev.of_node);`
`1530`		`- if (dsi->panel) {`
	`1530`	`+ if (IS_ERR(dsi->panel)) {`
	`1531`	`+ dsi->panel = NULL;`
	`1532`	`+ } else {`
`1531`	`1533`	`drm_panel_attach(dsi->panel, &dsi->connector);`
`1532`	`1534`	`dsi->connector.status = connector_status_connected;`
`1533`	`1535`	`}`