dmaengine: ep93xx: Return proper enum in ep93xx_dma_chan_direction

nathanchance · vinodkoul · commit 9524d6b265f9 · 2018-10-02T20:11:00.000+05:30
Clang warns when implicitly converting from one enumerated type to
another. Avoid this by using the equivalent value from the expected
type.

In file included from drivers/dma/ep93xx_dma.c:30:
./include/linux/platform_data/dma-ep93xx.h:88:10: warning: implicit
conversion from enumeration type 'enum dma_data_direction' to different
enumeration type 'enum dma_transfer_direction' [-Wenum-conversion]
                return DMA_NONE;
                ~~~~~~ ^~~~~~~~
1 warning generated.

Reported-by: Nick Desaulniers &lt;ndesaulniers@google.com&gt;
Signed-off-by: Nathan Chancellor &lt;natechancellor@gmail.com&gt;
Reviewed-by: Nick Desaulniers &lt;ndesaulniers@google.com&gt;
Signed-off-by: Vinod Koul &lt;vkoul@kernel.org&gt;
diff --git a/include/linux/platform_data/dma-ep93xx.h b/include/linux/platform_data/dma-ep93xx.h
@@ -85,7 +85,7 @@ static inline enum dma_transfer_direction
 ep93xx_dma_chan_direction(struct dma_chan *chan)
 {
 	if (!ep93xx_dma_chan_is_m2p(chan))
-		return DMA_NONE;
+		return DMA_TRANS_NONE;
 
 	/* even channels are for TX, odd for RX */
 	return (chan->chan_id % 2 == 0) ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM;

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ static inline enum dma_transfer_direction`
`85`	`85`	`ep93xx_dma_chan_direction(struct dma_chan *chan)`
`86`	`86`	`{`
`87`	`87`	`if (!ep93xx_dma_chan_is_m2p(chan))`
`88`		`- return DMA_NONE;`
	`88`	`+ return DMA_TRANS_NONE;`
`89`	`89`
`90`	`90`	`/* even channels are for TX, odd for RX */`
`91`	`91`	`return (chan->chan_id % 2 == 0) ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM;`