Skip to content

Commit 9dffff2

Browse files
Florian Westphalklassert
authored andcommitted
xfrm: policy: use hlist rcu variants on insert
bydst table/list lookups use rcu, so insertions must use rcu versions. Fixes: a7c4424 ("xfrm: policy: make xfrm_policy_lookup_bytype lockless") Signed-off-by: Florian Westphal <fw@strlen.de> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
1 parent 9f7e43d commit 9dffff2

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

net/xfrm/xfrm_policy.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -632,9 +632,9 @@ static void xfrm_hash_rebuild(struct work_struct *work)
632632
break;
633633
}
634634
if (newpos)
635-
hlist_add_behind(&policy->bydst, newpos);
635+
hlist_add_behind_rcu(&policy->bydst, newpos);
636636
else
637-
hlist_add_head(&policy->bydst, chain);
637+
hlist_add_head_rcu(&policy->bydst, chain);
638638
}
639639

640640
spin_unlock_bh(&net->xfrm.xfrm_policy_lock);
@@ -774,9 +774,9 @@ int xfrm_policy_insert(int dir, struct xfrm_policy *policy, int excl)
774774
break;
775775
}
776776
if (newpos)
777-
hlist_add_behind(&policy->bydst, newpos);
777+
hlist_add_behind_rcu(&policy->bydst, newpos);
778778
else
779-
hlist_add_head(&policy->bydst, chain);
779+
hlist_add_head_rcu(&policy->bydst, chain);
780780
__xfrm_policy_link(policy, dir);
781781

782782
/* After previous checking, family can either be AF_INET or AF_INET6 */

0 commit comments

Comments
 (0)