Skip to content

Commit 9f0916a

Browse files
Christoph Hellwigaxboe
authored andcommitted
nvme: add proper write zeroes setup for the multipath device
Add a gendisk argument to nvme_config_write_zeroes so that the call to nvme_update_disk_info for the multipath device node updates the proper request_queue. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Keith Busch <keith.busch@intel.com> Reviewed-by: Max Gurtovoy <maxg@mellanox.com> Tested-by: Sagi Grimberg <sagi@grimberg.me> Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 2631857 commit 9f0916a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/nvme/host/core.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1526,7 +1526,7 @@ static void nvme_config_discard(struct gendisk *disk, struct nvme_ns *ns)
15261526
blk_queue_max_write_zeroes_sectors(queue, UINT_MAX);
15271527
}
15281528

1529-
static inline void nvme_config_write_zeroes(struct nvme_ns *ns)
1529+
static void nvme_config_write_zeroes(struct gendisk *disk, struct nvme_ns *ns)
15301530
{
15311531
u32 max_sectors;
15321532
unsigned short bs = 1 << ns->lba_shift;
@@ -1549,7 +1549,7 @@ static inline void nvme_config_write_zeroes(struct nvme_ns *ns)
15491549
else
15501550
max_sectors = ((u32)(ns->ctrl->max_hw_sectors + 1) * bs) >> 9;
15511551

1552-
blk_queue_max_write_zeroes_sectors(ns->queue, max_sectors);
1552+
blk_queue_max_write_zeroes_sectors(disk->queue, max_sectors);
15531553
}
15541554

15551555
static void nvme_report_ns_ids(struct nvme_ctrl *ctrl, unsigned int nsid,
@@ -1607,7 +1607,7 @@ static void nvme_update_disk_info(struct gendisk *disk,
16071607
set_capacity(disk, capacity);
16081608

16091609
nvme_config_discard(disk, ns);
1610-
nvme_config_write_zeroes(ns);
1610+
nvme_config_write_zeroes(disk, ns);
16111611

16121612
if (id->nsattr & (1 << 0))
16131613
set_disk_ro(disk, true);

0 commit comments

Comments
 (0)