gpio: dwapb: Fix error handling in dwapb_gpio_probe()

khoroshilov · linusw · commit a618cf480097 · 2018-08-29T14:04:04.000+02:00
If dwapb_gpio_add_port() fails in dwapb_gpio_probe(),
gpio-&gt;clk is left undisabled.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov &lt;khoroshilov@ispras.ru&gt;
Signed-off-by: Linus Walleij &lt;linus.walleij@linaro.org&gt;
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
@@ -728,6 +728,7 @@ static int dwapb_gpio_probe(struct platform_device *pdev)
 out_unregister:
 	dwapb_gpio_unregister(gpio);
 	dwapb_irq_teardown(gpio);
+	clk_disable_unprepare(gpio->clk);
 
 	return err;
 }

Original file line number	Diff line number	Diff line change
`@@ -728,6 +728,7 @@ static int dwapb_gpio_probe(struct platform_device *pdev)`
`728`	`728`	`out_unregister:`
`729`	`729`	`dwapb_gpio_unregister(gpio);`
`730`	`730`	`dwapb_irq_teardown(gpio);`
	`731`	`+ clk_disable_unprepare(gpio->clk);`
`731`	`732`
`732`	`733`	`return err;`
`733`	`734`	`}`