Skip to content

Commit bc1a7f7

Browse files
hsinyi527Wolfram Sang
authored andcommitted
i2c: mediatek: modify threshold passed to i2c_get_dma_safe_msg_buf()
DMA with zero-length transfers doesn't make sense and this HW doesn't support them at all, so increase the threshold. Fixes: fc66b39 ("i2c: mediatek: Use DMA safe buffers for i2c transactions") Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> [wsa: reworded commit message] Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
1 parent ea29548 commit bc1a7f7

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/i2c/busses/i2c-mt65xx.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -503,7 +503,7 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs,
503503
writel(I2C_DMA_INT_FLAG_NONE, i2c->pdmabase + OFFSET_INT_FLAG);
504504
writel(I2C_DMA_CON_RX, i2c->pdmabase + OFFSET_CON);
505505

506-
dma_rd_buf = i2c_get_dma_safe_msg_buf(msgs, 0);
506+
dma_rd_buf = i2c_get_dma_safe_msg_buf(msgs, 1);
507507
if (!dma_rd_buf)
508508
return -ENOMEM;
509509

@@ -526,7 +526,7 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs,
526526
writel(I2C_DMA_INT_FLAG_NONE, i2c->pdmabase + OFFSET_INT_FLAG);
527527
writel(I2C_DMA_CON_TX, i2c->pdmabase + OFFSET_CON);
528528

529-
dma_wr_buf = i2c_get_dma_safe_msg_buf(msgs, 0);
529+
dma_wr_buf = i2c_get_dma_safe_msg_buf(msgs, 1);
530530
if (!dma_wr_buf)
531531
return -ENOMEM;
532532

@@ -549,7 +549,7 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs,
549549
writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_INT_FLAG);
550550
writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_CON);
551551

552-
dma_wr_buf = i2c_get_dma_safe_msg_buf(msgs, 0);
552+
dma_wr_buf = i2c_get_dma_safe_msg_buf(msgs, 1);
553553
if (!dma_wr_buf)
554554
return -ENOMEM;
555555

@@ -561,7 +561,7 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs,
561561
return -ENOMEM;
562562
}
563563

564-
dma_rd_buf = i2c_get_dma_safe_msg_buf((msgs + 1), 0);
564+
dma_rd_buf = i2c_get_dma_safe_msg_buf((msgs + 1), 1);
565565
if (!dma_rd_buf) {
566566
dma_unmap_single(i2c->dev, wpaddr,
567567
msgs->len, DMA_TO_DEVICE);

0 commit comments

Comments
 (0)