EDAC, sb_edac: Fix signedness bugs in *_get_ha() functions

aegl · suryasaimadhu · commit c968ed08594d · 2018-09-15T11:41:08.000+02:00
A static checker gave the following warnings: drivers/edac/sb_edac.c:1030 ibridge_get_ha() warn: signedness bug returning '(-22)' drivers/edac/sb_edac.c:1037 knl_get_ha() warn: signedness bug returning '(-22)' Both because the functions are declared to return a "u8", but try to return -EINVAL for the error case. Fix by returning 0xff (since the caller doesn't look at, or pass on, the return value). Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Tony Luck <tony.luck@intel.com> Cc: Qiuxu Zhuo <qiuxu.zhuo@intel.com> Cc: linux-edac <linux-edac@vger.kernel.org> Link: http://lkml.kernel.org/r/20180914201905.GA30946@agluck-desk Signed-off-by: Borislav Petkov <bp@suse.de>
diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
@@ -1027,14 +1027,14 @@ static u8 ibridge_get_ha(u8 bank)
 	case 9 ... 16:
 		return (bank - 9) / 4;
 	default:
-		return -EINVAL;
+		return 0xff;
 	}
 }
 
 /* Not used, but included for safety/symmetry */
 static u8 knl_get_ha(u8 bank)
 {
-	return -EINVAL;
+	return 0xff;
 }
 
 static u64 haswell_get_tolm(struct sbridge_pvt *pvt)

Original file line number	Diff line number	Diff line change
`@@ -1027,14 +1027,14 @@ static u8 ibridge_get_ha(u8 bank)`
`1027`	`1027`	`case 9 ... 16:`
`1028`	`1028`	`return (bank - 9) / 4;`
`1029`	`1029`	`default:`
`1030`		`- return -EINVAL;`
	`1030`	`+ return 0xff;`
`1031`	`1031`	`}`
`1032`	`1032`	`}`
`1033`	`1033`
`1034`	`1034`	`/* Not used, but included for safety/symmetry */`
`1035`	`1035`	`static u8 knl_get_ha(u8 bank)`
`1036`	`1036`	`{`
`1037`		`- return -EINVAL;`
	`1037`	`+ return 0xff;`
`1038`	`1038`	`}`
`1039`	`1039`
`1040`	`1040`	`static u64 haswell_get_tolm(struct sbridge_pvt *pvt)`