net: hns: Fix object reference leaks in hns_dsaf_roce_reset()

Huang Zijiang · davem330 · commit c969c6e7ab8c · 2019-02-14T12:28:52.000-05:00
The of_find_device_by_node() takes a reference to the underlying device
structure, we should release that reference.

Signed-off-by: Huang Zijiang &lt;huang.zijiang@zte.com.cn&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c
@@ -3081,13 +3081,15 @@ int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset)
 	dsaf_dev = dev_get_drvdata(&pdev->dev);
 	if (!dsaf_dev) {
 		dev_err(&pdev->dev, "dsaf_dev is NULL\n");
+		put_device(&pdev->dev);
 		return -ENODEV;
 	}
 
 	/* now, make sure we are running on compatible SoC */
 	if (AE_IS_VER1(dsaf_dev->dsaf_ver)) {
 		dev_err(dsaf_dev->dev, "%s v1 chip doesn't support RoCE!\n",
 			dsaf_dev->ae_dev.name);
+		put_device(&pdev->dev);
 		return -ENODEV;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -3081,13 +3081,15 @@ int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset)`
`3081`	`3081`	`dsaf_dev = dev_get_drvdata(&pdev->dev);`
`3082`	`3082`	`if (!dsaf_dev) {`
`3083`	`3083`	`dev_err(&pdev->dev, "dsaf_dev is NULL\n");`
	`3084`	`+ put_device(&pdev->dev);`
`3084`	`3085`	`return -ENODEV;`
`3085`	`3086`	`}`
`3086`	`3087`
`3087`	`3088`	`/* now, make sure we are running on compatible SoC */`
`3088`	`3089`	`if (AE_IS_VER1(dsaf_dev->dsaf_ver)) {`
`3089`	`3090`	`dev_err(dsaf_dev->dev, "%s v1 chip doesn't support RoCE!\n",`
`3090`	`3091`	`dsaf_dev->ae_dev.name);`
	`3092`	`+ put_device(&pdev->dev);`
`3091`	`3093`	`return -ENODEV;`
`3092`	`3094`	`}`
`3093`	`3095`