Input: uinput - add a schedule point in uinput_inject_events()

dtor · dtor · commit cecf10704899 · 2018-10-05T11:42:32.000-07:00
Large writes to uinput interface may cause rcu stalls. Let's add
cond_resched() to the loop to avoid this.

Reviewed-by: Paul E. McKenney &lt;paulmck@linux.ibm.com&gt;
Signed-off-by: Dmitry Torokhov &lt;dmitry.torokhov@gmail.com&gt;
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
@@ -598,6 +598,7 @@ static ssize_t uinput_inject_events(struct uinput_device *udev,
 
 		input_event(udev->dev, ev.type, ev.code, ev.value);
 		bytes += input_event_size();
+		cond_resched();
 	}
 
 	return bytes;

Original file line number	Diff line number	Diff line change
`@@ -598,6 +598,7 @@ static ssize_t uinput_inject_events(struct uinput_device *udev,`
`598`	`598`
`599`	`599`	`input_event(udev->dev, ev.type, ev.code, ev.value);`
`600`	`600`	`bytes += input_event_size();`
	`601`	`+ cond_resched();`
`601`	`602`	`}`
`602`	`603`
`603`	`604`	`return bytes;`