cpufreq: qcom-kryo: Fix section annotations

nathanchance · rafaeljw · commit d51aea13dd67 · 2018-09-29T15:01:10.000+02:00
There is currently a warning when building the Kryo cpufreq driver into the kernel image: WARNING: vmlinux.o(.text+0x8aa424): Section mismatch in reference from the function qcom_cpufreq_kryo_probe() to the function .init.text:qcom_cpufreq_kryo_get_msm_id() The function qcom_cpufreq_kryo_probe() references the function __init qcom_cpufreq_kryo_get_msm_id(). This is often because qcom_cpufreq_kryo_probe lacks a __init annotation or the annotation of qcom_cpufreq_kryo_get_msm_id is wrong. Remove the '__init' annotation from qcom_cpufreq_kryo_get_msm_id so that there is no more mismatch warning. Additionally, Nick noticed that the remove function was marked as '__init' when it should really be marked as '__exit'. Fixes: 46e2856 (cpufreq: Add Kryo CPU scaling driver) Fixes: 5ad7346 (cpufreq: kryo: Add module remove and exit) Reported-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Cc: 4.18+ <stable@vger.kernel.org> # 4.18+ Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
diff --git a/drivers/cpufreq/qcom-cpufreq-kryo.c b/drivers/cpufreq/qcom-cpufreq-kryo.c
@@ -44,7 +44,7 @@ enum _msm8996_version {
 
 struct platform_device *cpufreq_dt_pdev, *kryo_cpufreq_pdev;
 
-static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)
+static enum _msm8996_version qcom_cpufreq_kryo_get_msm_id(void)
 {
 	size_t len;
 	u32 *msm_id;
@@ -222,7 +222,7 @@ static int __init qcom_cpufreq_kryo_init(void)
 }
 module_init(qcom_cpufreq_kryo_init);
 
-static void __init qcom_cpufreq_kryo_exit(void)
+static void __exit qcom_cpufreq_kryo_exit(void)
 {
 	platform_device_unregister(kryo_cpufreq_pdev);
 	platform_driver_unregister(&qcom_cpufreq_kryo_driver);

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ enum _msm8996_version {`
`44`	`44`
`45`	`45`	`struct platform_device cpufreq_dt_pdev, kryo_cpufreq_pdev;`
`46`	`46`
`47`		`-static enum _msm8996_version __init qcom_cpufreq_kryo_get_msm_id(void)`
	`47`	`+static enum _msm8996_version qcom_cpufreq_kryo_get_msm_id(void)`
`48`	`48`	`{`
`49`	`49`	`size_t len;`
`50`	`50`	`u32 *msm_id;`
`@@ -222,7 +222,7 @@ static int __init qcom_cpufreq_kryo_init(void)`
`222`	`222`	`}`
`223`	`223`	`module_init(qcom_cpufreq_kryo_init);`
`224`	`224`
`225`		`-static void __init qcom_cpufreq_kryo_exit(void)`
	`225`	`+static void __exit qcom_cpufreq_kryo_exit(void)`
`226`	`226`	`{`
`227`	`227`	`platform_device_unregister(kryo_cpufreq_pdev);`
`228`	`228`	`platform_driver_unregister(&qcom_cpufreq_kryo_driver);`