ACPI / video: Extend chassis-type detection with a "Lunch Box" check

jwrdegoede · rafaeljw · commit d693c008e3ca · 2019-02-13T23:38:34.000+01:00
Commit 53fa1f6 ("ACPI / video: Only default only_lcd to true on Win8-ready _desktops_") introduced chassis type detection, limiting the lcd_only check for the backlight to devices where the chassis-type indicates their is no builtin LCD panel. The purpose of the lcd_only check is to avoid advertising a backlight interface on desktops, since skylake and newer machines seem to always have a backlight interface even if there is no LCD panel. The limiting of this check to desktops only was done to avoid breaking backlight support on some laptops which do not have the lcd flag set. The Fujitsu ESPRIMO Q910 which is a compact (NUC like) desktop machine has a chassis type of 0x10 aka "Lunch Box". Without the lcd_only check we end up falsely advertising backlight/brightness control on this device. This commit extend the dmi_is_desktop check to return true for type 0x10 to fix this. Fixes: 53fa1f6 ("ACPI / video: Only default only_lcd to true ...") Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
@@ -2143,6 +2143,7 @@ static bool dmi_is_desktop(void)
 	case 0x05: /* Pizza Box */
 	case 0x06: /* Mini Tower */
 	case 0x07: /* Tower */
+	case 0x10: /* Lunch Box */
 	case 0x11: /* Main Server Chassis */
 		return true;
 	}

Original file line number	Diff line number	Diff line change
`@@ -2143,6 +2143,7 @@ static bool dmi_is_desktop(void)`
`2143`	`2143`	`case 0x05: /* Pizza Box */`
`2144`	`2144`	`case 0x06: /* Mini Tower */`
`2145`	`2145`	`case 0x07: /* Tower */`
	`2146`	`+ case 0x10: /* Lunch Box */`
`2146`	`2147`	`case 0x11: /* Main Server Chassis */`
`2147`	`2148`	`return true;`
`2148`	`2149`	`}`