Skip to content

Commit d7d8fb7

Browse files
superna9999Andrzej Hajda
authored andcommitted
drm/meson: add HDMI div40 TMDS mode
Add support for TMDS Clock > 3.4GHz for HDMI2.0 display modes. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Link: https://patchwork.freedesktop.org/patch/msgid/1549022873-40549-3-git-send-email-narmstrong@baylibre.com
1 parent 264fce6 commit d7d8fb7

File tree

1 file changed

+19
-4
lines changed

1 file changed

+19
-4
lines changed

drivers/gpu/drm/meson/meson_dw_hdmi.c

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,8 @@ static int dw_hdmi_phy_init(struct dw_hdmi *hdmi, void *data,
365365
unsigned int wr_clk =
366366
readl_relaxed(priv->io_base + _REG(VPU_HDMI_SETTING));
367367

368-
DRM_DEBUG_DRIVER("\"%s\"\n", mode->name);
368+
DRM_DEBUG_DRIVER("\"%s\" div%d\n", mode->name,
369+
mode->clock > 340000 ? 40 : 10);
369370

370371
/* Enable clocks */
371372
regmap_update_bits(priv->hhi, HHI_HDMI_CLK_CNTL, 0xffff, 0x100);
@@ -385,9 +386,17 @@ static int dw_hdmi_phy_init(struct dw_hdmi *hdmi, void *data,
385386
/* Enable normal output to PHY */
386387
dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_BIST_CNTL, BIT(12));
387388

388-
/* TMDS pattern setup (TOFIX pattern for 4k2k scrambling) */
389-
dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_01, 0x001f001f);
390-
dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_23, 0x001f001f);
389+
/* TMDS pattern setup (TOFIX Handle the YUV420 case) */
390+
if (mode->clock > 340000) {
391+
dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_01, 0);
392+
dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_23,
393+
0x03ff03ff);
394+
} else {
395+
dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_01,
396+
0x001f001f);
397+
dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_23,
398+
0x001f001f);
399+
}
391400

392401
/* Load TMDS pattern */
393402
dw_hdmi_top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_CNTL, 0x1);
@@ -413,6 +422,8 @@ static int dw_hdmi_phy_init(struct dw_hdmi *hdmi, void *data,
413422
/* Disable clock, fifo, fifo_wr */
414423
regmap_update_bits(priv->hhi, HHI_HDMI_PHY_CNTL1, 0xf, 0);
415424

425+
dw_hdmi_set_high_tmds_clock_ratio(hdmi);
426+
416427
msleep(100);
417428

418429
/* Reset PHY 3 times in a row */
@@ -557,6 +568,10 @@ dw_hdmi_mode_valid(struct drm_connector *connector,
557568

558569
DRM_DEBUG_DRIVER("Modeline " DRM_MODE_FMT "\n", DRM_MODE_ARG(mode));
559570

571+
/* If sink max TMDS clock, we reject the mode */
572+
if (mode->clock > connector->display_info.max_tmds_clock)
573+
return MODE_BAD;
574+
560575
/* Check against non-VIC supported modes */
561576
if (!vic) {
562577
status = meson_venc_hdmi_supported_mode(mode);

0 commit comments

Comments
 (0)