kbuild: deb-pkg: avoid implicit effects

bonktree · masahir0y · commit f6d9db635522 · 2019-03-17T12:56:23.000+09:00
* The man page for dpkg-source(1) notes:

&gt;      -b, --build directory [format-specific-parameters]
&gt;             Build  a  source  package  (--build since dpkg 1.17.14).
&gt;             &lt;...&gt;
&gt;
&gt;             dpkg-source will build the source package with the first
&gt;             format found in this ordered list: the format  indicated
&gt;             with  the  --format  command  line  option,  the  format
&gt;             indicated in debian/source/format, “1.0”.  The  fallback
&gt;             to “1.0” is deprecated and will be removed at some point
&gt;             in the future, you should always  document  the  desired
&gt;             source   format  in  debian/source/format.  See  section
&gt;             SOURCE PACKAGE FORMATS for an extensive  description  of
&gt;             the various source package formats.

  Thus it would be more foolproof to explicitly use 1.0 (as we always
  did) than to rely on dpkg-source's defaults.

* In a similar vein, debian/rules is not made executable by mkdebian,
  and dpkg-source warns about that but still silently fixes the file.
  Let's be explicit once again.

Signed-off-by: Arseny Maslennikov &lt;ar@cs.msu.ru&gt;
Signed-off-by: Masahiro Yamada &lt;yamada.masahiro@socionext.com&gt;
diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
@@ -132,7 +132,9 @@ else
         echo >&2 "Install lsb-release or set \$KDEB_CHANGELOG_DIST explicitly"
 fi
 
-mkdir -p debian/
+mkdir -p debian/source/
+echo "1.0" > debian/source/format
+
 echo $debarch > debian/arch
 extra_build_depends=", $(if_enabled_echo CONFIG_UNWINDER_ORC libelf-dev)"
 extra_build_depends="$extra_build_depends, $(if_enabled_echo CONFIG_SYSTEM_TRUSTED_KEYRING libssl-dev:native)"
@@ -223,5 +225,6 @@ clean:
 
 binary: binary-arch
 EOF
+chmod +x debian/rules
 
 exit 0
