MIPS: mm: Remove redundant preempt_disable in local_flush_tlb_mm()

paulburton · paulburton · commit f7908a007e20 · 2019-02-04T10:56:22.000-08:00
The r4k variant of local_flush_tlb_mm() wraps its call to
drop_mmu_context() with a preempt_disable() &amp; preempt_enable() pair, but
this is redundant since drop_mmu_context() disables interrupts and from
Documentation/preempt-locking.txt:

  Note that you do not need to explicitly prevent preemption if you are
  holding any locks or interrupts are disabled, since preemption is
  implicitly disabled in those cases.

Remove the redundant preempt_disable() &amp; preempt_enable() calls.

Signed-off-by: Paul Burton &lt;paul.burton@mips.com&gt;
Cc: linux-mips@vger.kernel.org
diff --git a/arch/mips/mm/tlb-r4k.c b/arch/mips/mm/tlb-r4k.c
@@ -108,9 +108,7 @@ EXPORT_SYMBOL(local_flush_tlb_all);
    these entries, we just bump the asid. */
 void local_flush_tlb_mm(struct mm_struct *mm)
 {
-	preempt_disable();
 	drop_mmu_context(mm);
-	preempt_enable();
 }
 
 void local_flush_tlb_range(struct vm_area_struct *vma, unsigned long start,

Original file line number	Diff line number	Diff line change
`@@ -108,9 +108,7 @@ EXPORT_SYMBOL(local_flush_tlb_all);`
`108`	`108`	`these entries, we just bump the asid. */`
`109`	`109`	`void local_flush_tlb_mm(struct mm_struct *mm)`
`110`	`110`	`{`
`111`		`- preempt_disable();`
`112`	`111`	`drop_mmu_context(mm);`
`113`		`- preempt_enable();`
`114`	`112`	`}`
`115`	`113`
`116`	`114`	`void local_flush_tlb_range(struct vm_area_struct *vma, unsigned long start,`