clk: fixed-factor: fix of_node_get-put imbalance

ribalda · bebarino · commit f98e8a572bdd · 2018-11-06T08:27:52.000-08:00
When the fixed factor clock is created by devicetree, of_clk_add_provider is called. Add a call to of_clk_del_provider in the remove function to balance it out. Reported-by: Alan Tull <atull@kernel.org> Fixes: 971451b ("clk: fixed-factor: Convert into a module platform driver") Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c
@@ -210,6 +210,7 @@ static int of_fixed_factor_clk_remove(struct platform_device *pdev)
 {
 	struct clk *clk = platform_get_drvdata(pdev);
 
+	of_clk_del_provider(pdev->dev.of_node);
 	clk_unregister_fixed_factor(clk);
 
 	return 0;

Original file line number	Diff line number	Diff line change
`@@ -210,6 +210,7 @@ static int of_fixed_factor_clk_remove(struct platform_device *pdev)`
`210`	`210`	`{`
`211`	`211`	`struct clk *clk = platform_get_drvdata(pdev);`
`212`	`212`
	`213`	`+ of_clk_del_provider(pdev->dev.of_node);`
`213`	`214`	`clk_unregister_fixed_factor(clk);`
`214`	`215`
`215`	`216`	`return 0;`