Skip to content

Commit fc18751

Browse files
bcodding-rhTrond Myklebust
authored andcommitted
nfs: remove redundant call to nfs_context_set_write_error()
We don't need to call this in the direct, read, or pnfs resend paths and the only other caller is the write path in nfs_page_async_flush() which already checks and sets the pg_error on the context. Signed-off-by: Benjamin Coddington <bcodding@redhat.com> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
1 parent fdbd1a2 commit fc18751

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

fs/nfs/pagelist.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1174,10 +1174,6 @@ int nfs_pageio_add_request(struct nfs_pageio_descriptor *desc,
11741174
return 1;
11751175

11761176
out_failed:
1177-
/* remember fatal errors */
1178-
if (nfs_error_is_fatal(desc->pg_error))
1179-
nfs_context_set_write_error(req->wb_context,
1180-
desc->pg_error);
11811177
nfs_pageio_error_cleanup(desc);
11821178
return 0;
11831179
}

0 commit comments

Comments
 (0)