Skip to content

Commit fca269f

Browse files
Jianguo ChenMarc Zyngier
authored andcommitted
irqchip/mbigen: Don't clear eventid when freeing an MSI
mbigen_write_msg clears eventid bits of a mbigen register when free a interrupt, because msi_domain_deactivate memset struct msg to zero. Then multiple mbigen pins with zero eventid will report the same interrupt number. The eventid clear call trace: free_irq __free_irq irq_shutdown irq_domain_deactivate_irq __irq_domain_deactivate_irq __irq_domain_deactivate_irq msi_domain_deactivate platform_msi_write_msg mbigen_write_msg Signed-off-by: Jianguo Chen <chenjianguo3@huawei.com> [maz: massaged subject] Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
1 parent 6a77623 commit fca269f

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/irqchip/irq-mbigen.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,9 @@ static void mbigen_write_msg(struct msi_desc *desc, struct msi_msg *msg)
161161
void __iomem *base = d->chip_data;
162162
u32 val;
163163

164+
if (!msg->address_lo && !msg->address_hi)
165+
return;
166+
164167
base += get_mbigen_vec_reg(d->hwirq);
165168
val = readl_relaxed(base);
166169

0 commit comments

Comments
 (0)