Skip to content

Commit 21fb450

Browse files
recreate quantized shards of face recognition model, which apparently fixes the issue with karma loading the binary files + include quantized model tests for face recognition model
1 parent 234acd4 commit 21fb450

9 files changed

+11
-4287
lines changed

package-lock.json

Lines changed: 0 additions & 537 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/tests/faceRecognitionNet/faceRecognitionNet.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ describe('faceRecognitionNet', () => {
2222
faceDescriptor2 = await fetchJson<number[]>('base/test/data/faceDescriptor2.json')
2323
faceDescriptorRect = await fetchJson<number[]>('base/test/data/faceDescriptorRect.json')
2424
})
25+
2526
describeWithNets('quantized weights', { withFaceRecognitionNet: { quantized: true } }, ({ faceRecognitionNet }) => {
2627

2728
it('computes face descriptor for squared input', async () => {

test/tests/faceRecognitionNet/faceRecognitionNet.uncompressed.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@ import { fetchImage, fetchJson } from '../../../src';
22
import { euclideanDistance } from '../../../src/euclideanDistance';
33
import { describeWithNets } from '../../utils';
44

5-
// TODO: figure out why quantized weights results in NaNs in testcases
6-
// apparently (net weight values differ when loading with karma)
7-
xdescribe('faceRecognitionNet, uncompressed', () => {
5+
describe('faceRecognitionNet, uncompressed', () => {
86

97
let imgEl1: HTMLImageElement
108
let imgElRect: HTMLImageElement

test/tests/mtcnn/mtcnn.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ describe('mtcnn', () => {
6262
const deltas = {
6363
maxBoxDelta: 2,
6464
maxLandmarksDelta: 6,
65-
maxDescriptorDelta: 0.4
65+
maxDescriptorDelta: 0.2
6666
}
6767
expect(results.length).toEqual(6)
6868
expectFullFaceDescriptions(results, expectedFullFaceDescriptions, expectedScores, deltas)

test/tests/ssdMobilenetv1/ssdMobilenetv1.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ describe('ssdMobilenetv1', () => {
6161
const deltas = {
6262
maxBoxDelta: 5,
6363
maxLandmarksDelta: 1,
64-
maxDescriptorDelta: 0.01
64+
maxDescriptorDelta: 0.1
6565
}
6666
expect(results.length).toEqual(6)
6767
expectFullFaceDescriptions(results, expectedFullFaceDescriptions, expectedScores, deltas)

test/utils.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -200,9 +200,7 @@ export function describeWithNets(
200200
if (withFaceRecognitionNet || withAllFacesSsdMobilenetv1 || withAllFacesTinyFaceDetector|| withAllFacesMtcnn || withAllFacesTinyYolov2) {
201201
await initNet<FaceRecognitionNet>(
202202
faceRecognitionNet,
203-
// TODO: figure out why quantized weights results in NaNs in testcases
204-
// apparently (net weight values differ when loading with karma)
205-
'face_recognition_model.weights'
203+
!!withFaceRecognitionNet && !withFaceRecognitionNet.quantized && 'face_recognition_model.weights'
206204
)
207205
}
208206

weights/face_recognition_model-shard1

0 Bytes
Binary file not shown.

weights/face_recognition_model-shard2

Lines changed: 5 additions & 3741 deletions
Large diffs are not rendered by default.

weights/face_recognition_model-weights_manifest.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)