ensure a response callback sends only one response even if called multiple times

marcuswestin · marcuswestin · commit 2f3695749c11 · 2012-12-24T14:02:05.000-08:00
diff --git a/WebViewJavascriptBridge/WebViewJavascriptBridge.m b/WebViewJavascriptBridge/WebViewJavascriptBridge.m
@@ -136,7 +136,10 @@ - (void)_flushMessageQueue {
             WVJBResponseCallback responseCallback = NULL;
             __block NSString* callbackId = [message objectForKey:@"callbackId"];
             if (callbackId) {
+                __block bool wasCalled = false;
                 responseCallback = ^(id responseData) {
+                    if (wasCalled) { return; }
+                    wasCalled = true;
                     NSDictionary* message = [NSDictionary dictionaryWithObjectsAndKeys: callbackId, @"responseId", responseData, @"responseData", nil];
                     [self _queueMessage:message];
                 };
