Needs to replace global

carhartl · carhartl · commit 3e07441dd941 · 2013-01-24T23:00:25.000+01:00
diff --git a/jquery.cookie.js b/jquery.cookie.js
@@ -20,7 +20,7 @@
 	function unRfc2068(value) {
 		if (value.indexOf('"') === 0) {
 			// This is a quoted cookie as according to RFC2068, unescape
-			value = value.slice(1, -1).replace('\\"', '"').replace('\\\\', '\\');
+			value = value.slice(1, -1).replace(/\\"/g, '"').replace(/\\\\/g, '\\');
 		}
 		return value;
 	};
diff --git a/test.js b/test.js
@@ -35,8 +35,8 @@ test('not existing', function () {
 
 test('rfc2068 quoted string', function () {
 	expect(1);
-	document.cookie = 'c="v@address.com\\"\\\\"';
-	equal($.cookie('c'), 'v@address.com"\\', 'should decode rfc2068 quoted string');
+	document.cookie = 'c="v@address.com\\"\\\\\\""';
+	equal($.cookie('c'), 'v@address.com"\\"', 'should decode rfc2068 quoted string');
 });
 
 test('decode', function () {

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`	`function unRfc2068(value) {`
`21`	`21`	`if (value.indexOf('"') === 0) {`
`22`	`22`	`// This is a quoted cookie as according to RFC2068, unescape`
`23`		`- value = value.slice(1, -1).replace('\\"', '"').replace('\\\\', '\\');`
	`23`	`+ value = value.slice(1, -1).replace(/\\"/g, '"').replace(/\\\\/g, '\\');`
`24`	`24`	`}`
`25`	`25`	`return value;`
`26`	`26`	`};`