-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Roll customer_testing from 7f5502629 to 9a7ff449e (3 commits) #170544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for bumping this. I didn't realize we had to update this too.
@chrisbobbe Can you rebase or merge to fix the ci.yaml check? |
This pulls in the 3 commits below: flutter/tests@7f55026...9a7ff44 2025-06-11 cbobbe@zulip.com Bump Zulip pin to update some tests that hard-code route animation duration (flutter/tests#460) 2025-06-10 37781044+piotruela@users.noreply.github.com Bump patrol tests to b8bcebf96ff13e37fdc5474804d68e2352e472a4 (flutter/tests#451) 2025-06-02 21270878+elliette@users.noreply.github.com Re-enable DevTools tests (flutter/tests#459) (using the command from 5ce5251 / flutter#162763 to make the log). The latest change just went into flutter/tests yesterday and is why I'm making this PR.
@kenzieschmoll or @elliette it looks like some devtools customer tests fail are failing here, any idea why? This roll picks up this change to the devtools tests from 3 weeks ago: flutter/tests#459 |
I am not sure. I just bumped the Flutter SDK in DevTools to latest and all tests are passing there. I can update the flutter customer testing DevTools hash to |
Let's do that, thank you! So @chrisbobbe, after flutter/tests#461 is merged, we'll need to update this PR to the new SHA. |
As seen in this PR and also in flutter/tests#461, the patrol tests are failing. The patrol tests may need to be disabled to unblock both this PR and flutter/tests#461. |
I updated the PR. Now that flutter/tests#462 has merged, the failing customer tests (Patrol and Devtools, not Zulip) are disabled and hopefully this PR will go green. |
This pulls in the 3 commits below:
flutter/tests@7f55026...9a7ff44
2025-06-11 cbobbe@zulip.com Bump Zulip pin to update some tests that hard-code route animation duration (flutter/tests#460)
2025-06-10 37781044+piotruela@users.noreply.github.com Bump patrol tests to b8bcebf96ff13e37fdc5474804d68e2352e472a4 (flutter/tests#451)
2025-06-02 21270878+elliette@users.noreply.github.com Re-enable DevTools tests (flutter/tests#459)
(using the command from 5ce5251 / #162763 to make the log).
The latest change just went into flutter/tests yesterday and is why I'm making this PR.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.