Skip to content

Commit 78225bb

Browse files
authored
Create PULL_REQUEST_TEMPLATE.md
1 parent ece1364 commit 78225bb

File tree

1 file changed

+20
-0
lines changed

1 file changed

+20
-0
lines changed

PULL_REQUEST_TEMPLATE.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
## What is the purpose of the change
2+
3+
XXXXX
4+
5+
## Brief changelog
6+
7+
XX
8+
9+
## Verifying this change
10+
11+
XXXX
12+
13+
Follow this checklist to help us incorporate your contribution quickly and easily:
14+
15+
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/ROCKETMQ/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
16+
- [ ] Format the pull request title like `[ROCKETMQ-XXX] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
17+
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
18+
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-rocketmq/tree/master/test).
19+
- [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
20+
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).

0 commit comments

Comments
 (0)