Fix random int bug in SelectMessageQueueByRandom

释一 · zhouxinyu · commit e1a42e4ec756 · 2017-12-01T19:57:52.000+08:00
Author: 释一 <quanwei.lqw@alibaba-inc.com> Closes apache#173 from swwlqw/master.
diff --git a/client/src/main/java/org/apache/rocketmq/client/producer/selector/SelectMessageQueueByRandom.java b/client/src/main/java/org/apache/rocketmq/client/producer/selector/SelectMessageQueueByRandom.java
@@ -22,17 +22,12 @@
 import org.apache.rocketmq.common.message.Message;
 import org.apache.rocketmq.common.message.MessageQueue;
 
-public class SelectMessageQueueByRandoom implements MessageQueueSelector {
+public class SelectMessageQueueByRandom implements MessageQueueSelector {
     private Random random = new Random(System.currentTimeMillis());
 
     @Override
     public MessageQueue select(List<MessageQueue> mqs, Message msg, Object arg) {
-        int value = random.nextInt();
-        if (value < 0) {
-            value = Math.abs(value);
-        }
-
-        value = value % mqs.size();
+        int value = random.nextInt(mqs.size());
         return mqs.get(value);
     }
 }
