fix(directives) More robustness passing options

mchapman · mchapman · commit bd0e900be106 · 2015-02-05T19:16:07.000Z
diff --git a/dist/forms-angular.js b/dist/forms-angular.js
@@ -1,4 +1,4 @@
-/*! forms-angular 2015-02-04 */
+/*! forms-angular 2015-02-05 */
 'use strict';
 
 var formsAngular = angular.module('formsAngular', [
@@ -730,7 +730,7 @@ formsAngular
                   }
                 }
                 for (prop in options) {
-                  if (options.hasOwnProperty(prop) && prop[0] !== '$') {
+                  if (options.hasOwnProperty(prop) && prop[0] !== '$' && typeof options[prop] !== 'undefined') {
                     newElement += ' fng-opt-' + prop + '="' + options[prop].toString().replace(/"/g,'&quot;') + '"';
                   }
                 }
diff --git a/dist/forms-angular.min.js b/dist/forms-angular.min.js
diff --git a/js/directives/form.js b/js/directives/form.js
@@ -501,7 +501,7 @@ formsAngular
                   }
                 }
                 for (prop in options) {
-                  if (options.hasOwnProperty(prop) && prop[0] !== '$') {
+                  if (options.hasOwnProperty(prop) && prop[0] !== '$' && typeof options[prop] !== 'undefined') {
                     newElement += ' fng-opt-' + prop + '="' + options[prop].toString().replace(/"/g,'&quot;') + '"';
                   }
                 }
diff --git a/less/forms-angular-with-bs3.css b/less/forms-angular-with-bs3.css
@@ -5891,18 +5891,20 @@ form .schema-foot blockquote {
   border-color: rgba(0, 0, 0, 0.15);
 }
 form .schema-head {
-  margin-top: 0;
+  margin-top: 8px;
   margin-bottom: 5px;
   border: 1px solid #ddd;
   padding: 4px 180px;
 }
 form .sub-doc {
-  padding: 0 5px 0 0;
+  padding: 5px 5px 2px 0;
   width: 97%;
   margin-bottom: 3px;
+  position: relative;
 }
 form .sub-doc-btns {
-  margin-left: 15px;
+  position: absolute;
+  right: 8px;
 }
 form .schema-foot {
   padding: 5px 180px;
@@ -5985,9 +5987,14 @@ button.form-btn {
   font-size: 14px;
   padding: 2px 6px;
 }
-.form-horizontal .checkbox {
+.form-horizontal select.input-sm {
+  font-size: 14px;
   padding-left: 5px;
 }
+.form-horizontal .checkbox {
+  float: left;
+  padding: 5px 10px 0 6px;
+}
 .form-horizontal .control-label {
   padding-top: 6px;
 }
@@ -6040,6 +6047,9 @@ form .schema-foot {
   border: 1px solid #e3e3e3;
   border-radius: 4px;
 }
+form .sub-doc {
+  margin-left: 12px;
+}
 form .checkbox input[type="checkbox"] {
   margin-left: -5px;
 }

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/! forms-angular 2015-02-04 /`
	`1`	`+/! forms-angular 2015-02-05 /`
`2`	`2`	`'use strict';`
`3`	`3`
`4`	`4`	`var formsAngular = angular.module('formsAngular', [`
`@@ -730,7 +730,7 @@ formsAngular`
`730`	`730`	`}`
`731`	`731`	`}`
`732`	`732`	`for (prop in options) {`
`733`		`- if (options.hasOwnProperty(prop) && prop[0] !== '$') {`
	`733`	`+ if (options.hasOwnProperty(prop) && prop[0] !== '$' && typeof options[prop] !== 'undefined') {`
`734`	`734`	`newElement += ' fng-opt-' + prop + '="' + options[prop].toString().replace(/"/g,'"') + '"';`
`735`	`735`	`}`
`736`	`736`	`}`
Original file line number	Diff line number	Diff line change
`@@ -501,7 +501,7 @@ formsAngular`
`501`	`501`	`}`
`502`	`502`	`}`
`503`	`503`	`for (prop in options) {`
`504`		`- if (options.hasOwnProperty(prop) && prop[0] !== '$') {`
	`504`	`+ if (options.hasOwnProperty(prop) && prop[0] !== '$' && typeof options[prop] !== 'undefined') {`
`505`	`505`	`newElement += ' fng-opt-' + prop + '="' + options[prop].toString().replace(/"/g,'"') + '"';`
`506`	`506`	`}`
`507`	`507`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5891,18 +5891,20 @@ form .schema-foot blockquote {`
`5891`	`5891`	`border-color: rgba(0, 0, 0, 0.15);`
`5892`	`5892`	`}`
`5893`	`5893`	`form .schema-head {`
`5894`		`- margin-top: 0;`
	`5894`	`+ margin-top: 8px;`
`5895`	`5895`	`margin-bottom: 5px;`
`5896`	`5896`	`border: 1px solid #ddd;`
`5897`	`5897`	`padding: 4px 180px;`
`5898`	`5898`	`}`
`5899`	`5899`	`form .sub-doc {`
`5900`		`- padding: 0 5px 0 0;`
	`5900`	`+ padding: 5px 5px 2px 0;`
`5901`	`5901`	`width: 97%;`
`5902`	`5902`	`margin-bottom: 3px;`
	`5903`	`+ position: relative;`
`5903`	`5904`	`}`
`5904`	`5905`	`form .sub-doc-btns {`
`5905`		`- margin-left: 15px;`
	`5906`	`+ position: absolute;`
	`5907`	`+ right: 8px;`
`5906`	`5908`	`}`
`5907`	`5909`	`form .schema-foot {`
`5908`	`5910`	`padding: 5px 180px;`
`@@ -5985,9 +5987,14 @@ button.form-btn {`
`5985`	`5987`	`font-size: 14px;`
`5986`	`5988`	`padding: 2px 6px;`
`5987`	`5989`	`}`
`5988`		`-.form-horizontal .checkbox {`
	`5990`	`+.form-horizontal select.input-sm {`
	`5991`	`+ font-size: 14px;`
`5989`	`5992`	`padding-left: 5px;`
`5990`	`5993`	`}`
	`5994`	`+.form-horizontal .checkbox {`
	`5995`	`+ float: left;`
	`5996`	`+ padding: 5px 10px 0 6px;`
	`5997`	`+}`
`5991`	`5998`	`.form-horizontal .control-label {`
`5992`	`5999`	`padding-top: 6px;`
`5993`	`6000`	`}`
`@@ -6040,6 +6047,9 @@ form .schema-foot {`
`6040`	`6047`	`border: 1px solid #e3e3e3;`
`6041`	`6048`	`border-radius: 4px;`
`6042`	`6049`	`}`
	`6050`	`+form .sub-doc {`
	`6051`	`+ margin-left: 12px;`
	`6052`	`+}`
`6043`	`6053`	`form .checkbox input[type="checkbox"] {`
`6044`	`6054`	`margin-left: -5px;`
`6045`	`6055`	`}`