Skip to content

Commit fe2ce04

Browse files
mchapmanmchapman
committed
fix(search) Make search controller a bit more robust
1 parent 5b2fa19 commit fe2ce04

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

‎dist/forms-angular.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ var fng;
306306
})();
307307
$scope.searchPlaceholder = _isNotMobile ? 'Ctrl + / to Search' : 'Search';
308308
$scope.handleKey = function (event) {
309-
if (event.keyCode === 27 && $scope.searchTarget.length > 0) {
309+
if (event.keyCode === 27 && $scope.searchTarget && $scope.searchTarget.length > 0) {
310310
$scope.searchTarget = '';
311311
}
312312
else if ($scope.results.length > 0) {

‎dist/forms-angular.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/forms-angular.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎js/controllers/search-ctrl.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ module fng.controllers {
2424
$scope.searchPlaceholder = _isNotMobile ? 'Ctrl + / to Search' : 'Search';
2525

2626
$scope.handleKey = function (event) {
27-
if (event.keyCode === 27 && $scope.searchTarget.length > 0) {
27+
if (event.keyCode === 27 && $scope.searchTarget && $scope.searchTarget.length > 0) {
2828
$scope.searchTarget = '';
2929
} else if ($scope.results.length > 0) {
3030
switch (event.keyCode) {

0 commit comments

Comments
 (0)