Skip to content

Commit 6a7c786

Browse files
committed
Minor cleanup for the added reduce support in the view server.
--HG-- extra : convert_revision : svn%3A7a298fb0-333a-0410-83e7-658617cd9cf3/trunk%4078
1 parent 0f433e6 commit 6a7c786

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

couchdb/view.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,10 @@ def reduce(*cmd, **kwargs):
9191
try:
9292
exec code in {}, globals_
9393
except Exception, e:
94-
return {'error': {'id': 'reduce_compilation_error', 'reason': e.args[0]}}
94+
return {'error': {
95+
'id': 'reduce_compilation_error',
96+
'reason': e.args[0]
97+
}}
9598
err = {'error': {
9699
'id': 'reduce_compilation_error',
97100
'reason': 'string must eval to a function (ex: "def(doc): return 1")'
@@ -103,18 +106,18 @@ def reduce(*cmd, **kwargs):
103106
return err
104107

105108
results = []
106-
keys,vals = zip(*args)
107-
if(function.func_code.co_argcount == 3):
108-
rereduce = kwargs['rereduce'] if kwargs.has_key('rereduce') else False
109-
results = function(keys, vals, rereduce)
109+
keys, vals = zip(*args)
110+
if function.func_code.co_argcount == 3:
111+
results = function(keys, vals, kwargs.get('rereduce', False))
110112
else:
111113
results = function(keys, vals)
112114
return [True, [results]]
113115

114116
def rereduce(*cmd):
115117
reduce(cmd, rereduce=True)
116118

117-
handlers = {'reset': reset, 'add_fun': add_fun, 'map_doc': map_doc, 'reduce': reduce, 'rereduce': rereduce}
119+
handlers = {'reset': reset, 'add_fun': add_fun, 'map_doc': map_doc,
120+
'reduce': reduce, 'rereduce': rereduce}
118121

119122
try:
120123
while True:

0 commit comments

Comments
 (0)