resetForm now clears old previousValue on form elements. Fixes jquery-validation#312

mlynch · mlynch · commit f0b804223343 · 2012-05-04T10:48:49.000-05:00
diff --git a/jquery.validate.js b/jquery.validate.js
@@ -410,7 +410,7 @@ $.extend($.validator, {
 			this.lastElement = null;
 			this.prepareForm();
 			this.hideErrors();
-			this.elements().removeClass( this.settings.errorClass );
+			this.elements().removeClass( this.settings.errorClass ).removeData( "previousValue" );
 		},
 
 		numberOfInvalids: function() {
diff --git a/test/methods.js b/test/methods.js
@@ -495,16 +495,16 @@ asyncTest("remote radio correct value sent", function() {
 	v.element(e);
 });
 
-asyncTest("remote correct number of invalids", function() {
-	expect(4);
+asyncTest("remote reset clear old value", function() {
+	expect(1);
+
 	var e = $("#username");
 	var v = $("#userForm").validate({
 		rules: {
 			username: {
 				required: true,
 				remote: {
 					url: "echo.php",
-					dataType: 'json',
 					dataFilter: function(data) {
 						var json = JSON.parse(data);
 						if(json.username == 'asdf') {
@@ -514,33 +514,31 @@ asyncTest("remote correct number of invalids", function() {
 					}
 				}
 			}
-		},
-		messages: {
-			username: {
-				required: "Please"
-			}
-		},
-		submitHandler: function() {
-			ok( false, "submitHandler may never be called when validating only elements");
 		}
 	});
 	$(document).ajaxStop(function() {
+		var waitTimeout;
+
 		$(document).unbind("ajaxStop");
-		equal( 1, v.numberOfInvalids(), "There must be one error" );
 
-		e.val("max");
 
 		$(document).ajaxStop(function() {
-			equal( 0, v.numberOfInvalids(), "There must not be any errors" );
+			clearTimeout(waitTimeout);
+			ok( true, "Remote request sent to server" );
 			start();
 		});
 
+
+		v.resetForm();
+		e.val("asdf");
+		waitTimeout = setTimeout(function() {
+			ok( false, "Remote server did not get request");
+			start();
+		}, 200);
 		v.element(e);
 	});
-	strictEqual( v.element(e), false, "invalid element, nothing entered yet" );
 	e.val("asdf");
-  strictEqual( v.numberOfInvalids(), 1, "still invalid, because remote validation must block until it returns; dependency-mismatch considered as valid though" );
-  v.element(e);
+	v.element(e);
 });
 
 module("additional methods");
diff --git a/test/test.js b/test/test.js
@@ -26,7 +26,8 @@ $.mockjax({
 	url: "echo.php",
 	response: function(data) {
 		this.responseText = JSON.stringify(data.data);
-	}
+	},
+	responseTime: 100
 });
 
 module("validator");
