Merge pull request #112 from nerijunior/fix/sanitization-accepting-nulls

vicentimartins · web-flow · commit ef0ba8f1623d · 2021-04-22T20:38:43.000-03:00
Fix Sanitization class to deal with null values
diff --git a/src/validator-docs/Rules/Sanitization.php b/src/validator-docs/Rules/Sanitization.php
@@ -10,6 +10,6 @@ abstract class Sanitization
 {
     public function sanitize($value): string
     {
-        return preg_replace('/[^\d]/', '', $value);
+        return empty($value) ? "" : preg_replace('/[^\d]/', '', $value);
     }
 }
diff --git a/tests/SanitizationTestCase.php b/tests/SanitizationTestCase.php
@@ -0,0 +1,23 @@
+<?php
+
+namespace geekcom\ValidatorDocs\Tests;
+
+use geekcom\ValidatorDocs\Rules\Sanitization;
+use Illuminate\Support\Facades\Validator;
+
+final class SanitizationTestCase extends ValidatorTestCase
+{
+    /** @test **/
+    public function sanitizeRetornaVazioQuandoNuloOuVazio()
+    {
+        $mock = $this->getMockForAbstractClass(Sanitization::class);
+        $this->assertEquals($mock->sanitize(null), "");
+    }
+
+    /** @test **/
+    public function sanitizeRetornaSomenteDigitos()
+    {
+        $mock = $this->getMockForAbstractClass(Sanitization::class);
+        $this->assertEquals($mock->sanitize('a53.084.587/0001-20z'), "53084587000120");
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,6 @@ abstract class Sanitization`
`10`	`10`	`{`
`11`	`11`	`public function sanitize($value): string`
`12`	`12`	`{`
`13`		`- return preg_replace('/[^\d]/', '', $value);`
	`13`	`+ return empty($value) ? "" : preg_replace('/[^\d]/', '', $value);`
`14`	`14`	`}`
`15`	`15`	`}`